search

onsi / ginkgo

A Modern Testing Framework for Go
http://onsi.github.io/ginkgo/
MIT License
8.09k stars 643 forks source link

core_dsl: disable Getwd() with environment variable #1357

Closed kevinburke closed 4 months ago

kevinburke commented 5 months ago

os.Getwd() calls os.Getenv("PWD"), which can change from run to run if you are using a test suite runner like e.g. Buildkite. Because test caching relies on environment variables being the same from run to run, this facile change breaks test caching.

Fixes #1355.

onsi commented 4 months ago

sorry for the delay - thanks for this!