search

onsi / ginkgo

A Modern Testing Framework for Go
http://onsi.github.io/ginkgo/
MIT License
8.09k stars 643 forks source link

add `--github-output` for nicer output in github actions #1373

Closed lahabana closed 3 months ago

lahabana commented 3 months ago

Leverage github's special formats to output nicer output

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#using-workflow-commands-to-access-toolkit-functions

Fix #1372

lahabana commented 3 months ago

@onsi putting that in draft I still need to validate a few things but that's the rough idea for the change

onsi commented 3 months ago

hey that looks great. the tests for the reporter are a bit long/verbose but will you be adding one as well?

also can you update Ginkgo's own test.yml to use the feature? Thanks!

lahabana commented 3 months ago

@onsi I added 1 test (they are indeed quite tricky to write...) let me know if you want more tests

onsi commented 3 months ago

hey thanks. no the one is good - just want to make sure future work doesn't break this feature.

lahabana commented 3 months ago

Ok I'll undraft this once I've checked the output in: https://github.com/kumahq/kuma/pull/9603 looks good

lahabana commented 3 months ago

@onsi I think it's ready!

onsi commented 3 months ago

great! i’ll merge it in when CI finishes and will cut a release soon.

onsi commented 3 months ago

done! thank you :)