search

onsi / ginkgo

A Modern Testing Framework for Go
http://onsi.github.io/ginkgo/
MIT License
8.38k stars 660 forks source link

fix: missing commas #1475

Closed monteiro-renato closed 2 weeks ago

onsi commented 2 weeks ago

hey thanks for all of these tweaks. this one no longer merges in, would you be up for rebasing it?

also - while i appreciate separating the work into tiny chunks. a single PR with all these fixes would have worked fine for me as well.

monteiro-renato commented 2 weeks ago

Hey 👋 I've fixed the merge conflict now.

Sorry for the noise! 😅 For simple tweaks like these I usually just edit the files directly via GitHub UI as I find them. I will try to compile all into a single PR if I find more tweaks to be made.

onsi commented 2 weeks ago

thanks! i appreciate you taking the time to fix these things!