Closed akalenyu closed 4 days ago
@onsi Are the failures caused by the PR?
yes - this line:
https://github.com/onsi/ginkgo/blob/master/integration/timeline_test.go#L141
needs to changed to a full timeline [Serial]\n
you should be able to ginkgo -r -p
from the root directory and see it all go green. Every now and then an integration spec will flake on a slow machine but they are generally pretty reliable so if you see a failure it’s probably the new code. In this case adding Serial
as a label changed the output and we’ll need to update the test.
yes - this line:
https://github.com/onsi/ginkgo/blob/master/integration/timeline_test.go#L141
needs to changed to
a full timeline [Serial]\n
you should be able to
ginkgo -r -p
from the root directory and see it all go green. Every now and then an integration spec will flake on a slow machine but they are generally pretty reliable so if you see a failure it’s probably the new code. In this case addingSerial
as a label changed the output and we’ll need to update the test.
Added. I couldn't understand who sets the serial decorator on this timeline test though
yay! that worked. will cut a release soon
yay! that worked. will cut a release soon
hey, are you planning to cut a release?
done!
done!
thank you!
Adding a label in order to be able to filter tests decorated with
Serial
.Fixes #1483