onsi / gomega

Ginkgo's Preferred Matcher Library
http://onsi.github.io/gomega/
MIT License
2.13k stars 282 forks source link

Does this make sens? Eventually(..., "1s", "2s", ctx).Should(...) #751

Closed guettli closed 2 months ago

guettli commented 2 months ago

From the docs at: https://github.com/onsi/gomega/blob/master/gomega_dsl.go#L375C2-L375C46

Eventually(..., "1s", "2s", ctx).Should(...)

I think this example makes no sense.

If the timeout is 1s, then there will never be polling.

onsi commented 2 months ago

durp. thanks - the example is indeed confusing. I've changed it to "10s", "2s"