search

onsi / gomega

Ginkgo's Preferred Matcher Library
http://onsi.github.io/gomega/
MIT License
2.16k stars 282 forks source link

issue_765 - fixed bug in Hopcroft-Karp algorithm #766

Closed timmyb32r closed 2 months ago

timmyb32r commented 3 months ago

see https://github.com/onsi/gomega/issues/765

onsi commented 3 months ago

hi - thanks for digging into this and providing a fix. sorry for the delay but i'm going to need to find some time to understand this and pull it in (and rewrite the test into a ginkgo test to match the other tests in the package). hope to get to it in the next few weeks.

onsi commented 2 months ago

thanks! I've pulled this in and updated the tests to match the existing test style

gibizer commented 2 months ago

Hi! This patch seems to be causing issue with golang 1.20 due to slices is not in 1.20 only from 1.21

When bumping to gomega 1.34.0 I see:

/home/gibi/go/pkg/mod/github.com/onsi/gomega@v1.34.0/matchers/support/goraph/bipartitegraph/bipartitegraphmatching.go:4:2: package slices is not in GOROOT (/usr/lib/go-1.20/src/slices)

See a public bump failure in https://github.com/openstack-k8s-operators/nova-operator/pull/837#issuecomment-2253749772