onsip / SIP.js

A simple, intuitive, and powerful JavaScript signaling library
https://sipjs.com
MIT License
1.84k stars 693 forks source link

Clarification Needed on Logger/LoggerFactory Usage #1084

Open netanelb-carbyne opened 1 month ago

netanelb-carbyne commented 1 month ago

Dear Team,

I hope this message finds you well.

I would like to bring to your attention a critical issue regarding our current usage of the eslint rule no-console. This rule exists for a reason, and it's crucial that we address its implications properly.

Here is an example scenario to illustrate the problem:

  1. An error occurs in the code.
  2. The logger is activated.
  3. As a program, we are unable to determine what exactly happened.

To resolve this, it is essential to clearly define the purpose of our logger:

By addressing this issue, we can ensure that our logging practices are both effective and compliant with best practices.

Thank you for your attention to this matter. I look forward to your feedback and suggestions.

Best regards, Netanel Baba