0.6.0: Webcam Light Comes on Even if Video set to false

[lylepratt]

Hi Guys. Just doing some testing on the new 0.6.0 release. Have found one minor issue:

When I accept a call with video: false, my webcam light is coming on as if Video is actually active. It did not do this on the 0.5.0 branch.

Here is the code i'm using to accept the call:

    session.accept({
        media: {
          audio: true,
          video: false,
          render: {
            remote: {
              audio: document.createElement('audio')
            }
          }
        }
      });

[josephfrazier]

Hey Lyle, thanks for the testing!

The syntax for the media property has changed slightly. You now need to put the constraints inside a constraints property. Try this instead:

    session.accept({
        media: {
            constraints: {
                audio: true,
                video: false
            },
            render: {
                remote: {
                    audio: document.createElement('audio')
                }
            }
        }
    });

I'll work on getting together a guide for migrating from 0.5.0. In the meantime, here's what's come to mind so far:

• The Session's referred event has been removed. See the commit message of https://github.com/onsip/SIP.js/commit/3115223d0482dcfdb278da956d61da18d099c6b2 for an alternative.
• The Session's refer event handler's first argument is now a request, not a uri. The uri can be obtained as follows:

session.on('refer', function handleRefer (request) {
  var uri = request.parseHeader('refer-to').uri;
});

• If your application calls SIP.WebRTC.* functions directly, it should first call SIP.WebRTC.isSupported to ensure they are available.
• Using string constants for the rel100 UA Configuration Parameter has been deprecated (but still works for now). Applications should use SIP.C.supported constants instead. See http://sipjs.com/api/0.6.0/ua_configuration_parameters/#rel100

Let us know if you run into any more backwards incompatibilities, Joseph

[lylepratt]

Awesome that worked! Thanks for the other tips as well. The only other issue I've encountered so far was on mobile. I opened a separate issue for it here: https://github.com/joseph-onsip/sipjs-cordova/issues/4

[james-criscuolo]

Hi Lyle, It seems like this issue has been resolved, so I'm going to close it, but feel free to re-open it if the problem re-emerges.