PoA now uses an authority instead of genesis admin params. The SDK's limit of just 1 authority per module was far to confusing to allow multiple to control the set, but only 1 admin who can upgrade the module.
Something like the following is recommended to make it easy for validators to update the PoA admin at runtime, as well as for your own testing. You can also just hardcode the address, but it does make it hard to unit & e2e test.
// GetPoAAdmin by default uses the governance address as typically expected.
// If you decide a single wallet / multisig should have control, the chain validators can set
// POA_ADMIN_ADDRESS=address1... appd start
// or you can ignore this function and just hardcode the address1... into all the NewKeeper()'s
func GetPoAAdmin() string {
if addr := os.Getenv("POA_ADMIN_ADDRESS"); addr != "" {
_, err := sdk.AccAddressFromBech32(addr)
if err != nil {
panic(fmt.Sprintf("invalid POA_ADMIN_ADDRESS: %s", addr))
}
return addr
}
return authtypes.NewModuleAddress(govtypes.ModuleName).String()
}
2) New Ante Disable for Withdrawing Rewards
You should now use poaante.NewPOADisableWithdrawDelegatorRewards(), in your ante.go to disable validators from attempting to withdraw rewards.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps github.com/strangelove-ventures/poa from 0.50.0 to 0.50.4.
Release notes
Sourced from github.com/strangelove-ventures/poa's releases.
... (truncated)
Commits
7a15132
feat: poa authority query (#218)e3e1f58
ci: coverage report and badges (#211)8d1a5f4
docs: update doc to reflect latest changes (#212)d321226
fix!: use authority admin, remove params (#184)189d0e7
test!: nested msg tests (#207)54217d0
feat(cov): add simulator tests to coverage (#204)eea4ca7
chore(qol): govulncheck, go vet & bumps (#206)82ae5af
feat(v2): wiring v2 (#202)3595e3d
fix(ante): prevent nested withdraw delegator rewards (#201)93d500b
feat!: simulator support (#186)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show