onthegomap / maplibre-contour

Render contour lines from raster DEM tiles in maplibre-gl-js
https://onthegomap.github.io/maplibre-contour/
Other
168 stars 16 forks source link

[Protocol Support]: Add support for fetching non-https protocols #263

Closed fallaciousreasoning closed 3 months ago

fallaciousreasoning commented 3 months ago

Hey, thanks for the great plugin, it works really well. I've forked the repo and hacked in support for custom protocols so I can load tiles from IndexedDB. Would you be interested in a PR for the feature (if I clean it up)?

I know that this repo is probably going to be deprecated once https://github.com/maplibre/maplibre-style-spec/issues/583 is resolved (and it'll give us native protocol support) but thought I'd check.

msbarry commented 3 months ago

Thanks for reaching out! I'd rather not update/maintain any extra functionality in this plugin between now and when I get it incorporated as a first-class feature in maplibre. That IndexedDB functionality seems handy though as a way to load tiles when offline, is it open source? If not that might be an interesting project to make available for projects to use with other maplibre sources?

fallaciousreasoning commented 3 months ago

Yeah, figured that might be the case :smile: It is yeah, but just as part of my side project https://alpha.topos.nz https://github.com/fallaciousreasoning/topo/blob/alpha-react/src/caches/cachingProtocol.ts

I could probably move it into its own thing pretty easily. Okay, going to close this as wontfix