By default, sourceFeature.featureIdFromElement() is using sourceFeature.id(), but it allows overiding it in sub-classes, such as OsmElement.
For OSM elements, the feature id encodes the origin of a vector tile feature - an OSM node, way, or relation. It uses the formula
{vector tile feature id} = {osm id} * 10 + {1 for node, 2 for way, 3 for relation}. See #824
A default implementation for featureIdFromElement() added to sourceFeature
A OsmElement.type() implemented in its sub-classes to provide the OSM element type.
OsmElement.featureIdFromElement() uses type() to implemented the above formula.
source.featureIdFromElement() is used instead of source.id() when converting a source element to a tile feature in FeatureCollector, OpenMapTilesMapping, and OsmFeature.
Additional constructors to avoid the use of withId() in tests
By default,
sourceFeature.featureIdFromElement()is usingsourceFeature.id(), but it allows overiding it in sub-classes, such asOsmElement.For OSM elements, the feature id encodes the origin of a vector tile feature - an OSM node, way, or relation. It uses the formula
{vector tile feature id} = {osm id} * 10 + {1 for node, 2 for way, 3 for relation}. See #824featureIdFromElement()added tosourceFeatureOsmElement.type()implemented in its sub-classes to provide the OSM element type.OsmElement.featureIdFromElement()usestype()to implemented the above formula.source.featureIdFromElement()is used instead ofsource.id()when converting a source element to a tile feature inFeatureCollector,OpenMapTilesMapping, andOsmFeature.withId()in tests