search

ontodev / cogs

COGS Operates Google Sheets
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Fail on pushing with no headers #99

Closed beckyjackson closed 3 years ago

beckyjackson commented 3 years ago

Resolves #98

Same error message as trying to add with no headers.

jamesaoverton commented 3 years ago

This looks right, but do we also want to check at other times, such as pull? I'm not sure.

beckyjackson commented 3 years ago

That's a good question... and I don't know. You can fetch a sheet without headers just fine, and technically we could update push and add to be able to handle sheets without headers... Maybe that's the better solution? But I feel like if you're handling a sheet without headers, something is wrong.

jamesaoverton commented 3 years ago

We were using headers for the .cogs/field.tsv table. Now I think that was a mistake, and I was mixing up my ideas about COGS and VALVE. So I don't think we need .cogs/field.tsv in COGS, and we probably don't need COGS to know about the headers at all. What do you think?

jamesaoverton commented 3 years ago

We agreed to drop .cogs/field.tsv, and then we don't need to check for headers anywhere.

beckyjackson commented 3 years ago

Closing in favor of #100