Miscellaneous fixes and improvements

ontodev / droid

DROID Reminds us that Ordinary Individuals can be Developers

BSD 3-Clause "New" or "Revised" License

4 stars 1 forks source link

Miscellaneous fixes and improvements #108

Closed lmcmicu closed 3 years ago

lmcmicu commented 3 years ago

Fixes #103, closes #106, closes #104, closes #105, closes #45, closes #101

Note: After applying this change, please

Stop droid.
Remove the db/ sudirectory in DROID's main directory
Restart DROID.

Any previously logged in users will then have to log in again. (This only needs to be done once.)

lmcmicu commented 3 years ago

Unfortunately I need to convert this PR back into draft mode. Upgrading the ring library has had an impact on the way joda-time objects are stored in the ring header which requires us to 'unquarantine' them before reading them. Some code was added to handle this but it seems it is not working correctly.

I think we should consider reversing the upgrade of ring here and opening a new (small) PR to deal just with this upgrade; i.e.,

reverse the upgrade of the ring library
merge this PR once it has been tested
open a new PR to deal with the upgrade of ring.

jamesaoverton commented 3 years ago

I finally got a chance to deploy and test this. I noticed one (hopefully) small change I would like, and everything else looks exactly right.

The one small change is that when you click "Follow console", the page should scroll to the bottom right away. Currently it waits five seconds and then scrolls to the bottom.

lmcmicu commented 3 years ago

Ok, I have just pushed a commit (https://github.com/ontodev/droid/pull/108/commits/7b1615cbcf9afeaafc33907abc4b49eb9d46fde0) to scroll to the bottom of the page after the page is loaded whenever auto-refresh is set.