search

ontodev / robot

ROBOT is an OBO Tool
http://robot.obolibrary.org
BSD 3-Clause "New" or "Revised" License
259 stars 73 forks source link

Bump OWLAPI version to match Protege #668

Open jamesaoverton opened 4 years ago

jamesaoverton commented 4 years ago

I like to stay in sync the the version of OWLAPI used by the latest release of Protege. It looks like we're behind:

It would be nice to have an automated check for this, maybe in util/release.sh.

balhoff commented 3 years ago

Some notes on OWLAPI version issues for ROBOT in https://github.com/ontodev/robot/issues/759#issuecomment-720115992

bjonnh commented 3 years ago

Do we still want to follow that even if Protégé had no updates for a year?

jamesaoverton commented 3 years ago

@bjonnh You're right, we should reconsider this policy.

matentzn commented 3 years ago

The reason for this policy is that many of our users are using Protege and we need to avoid spurious diffs on GitHub... What would be the reason to update to a newer OWL API version?

jamesaoverton commented 3 years ago

I mean a newer patch version, in the 4.5.x series. The reason is to benefit from bug fixes to OWLAPI.

matentzn commented 3 years ago

Hopeing the serialisers are not affected by patch versions :P

dosumis commented 3 years ago

Can we test serialisation before we make a move? IIRC, we have a standard diff-able serialization for functional syntax (specifies ordering for situations where multiple orders are possible for the same semantics) so this shouldn't matter, but I'd still like to see tests to confirm.

jamesaoverton commented 2 years ago

It's been a year, the situation is unchanged, and it's increasingly untenable. I think we should move ROBOT to the newest OWLAPI in the 4.x series, which seems to be 4.5.20 released 2021-07-31. And then we should stick with OWLAPI releases as they come out.

matentzn commented 2 years ago

@matthewhorridge is it feasible to coordinate this with a Protege release in January?