search

ontodev / sprocket

BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Handle *_meta columns #18

Closed beckyjackson closed 2 years ago

beckyjackson commented 2 years ago

Resolves #13 - replaces null values Resolves #14 - highlighting cells based on violation level, messages in tooltip Resolves #15 - filtering by violation Resolves #16 - expand rows with violations

jamesaoverton commented 2 years ago

It would be easier to review with some test files. Even just copying the examples from the issues into test files would be helpful.

beckyjackson commented 2 years ago

I will add that. After some playing around, I noticed that there are a couple of bugs after filtering violations, and with the next/previous buttons. I'm going to set this back to a draft PR and make sure those are resolved first.

beckyjackson commented 2 years ago

OK - it should be resolved now.

jamesaoverton commented 2 years ago

I don't see a tests/resources/test.sql file.

beckyjackson commented 2 years ago

Sorry, added!