search

ontodev / valve.js

VALVE in JavaScript
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Fix test #9

Closed beckyjackson closed 3 years ago

beckyjackson commented 3 years ago

All strings need to be surrounded with double quotes, so I updated the Makefile to reflect this.

I also added a task to the Makefile to test ignoring newlines and whitespace between the expected and actual output. If there is a difference, the output isn't super helpful, but it will at least pass even if the formatting is different. This way I can more easily catch issues, rather than trying to manually check the outputs.

I guess diff -w doesn't work with newlines, so I'm wondering if there's a better way to do this?

Regex flags was also undefined in the expected output, when no flags return an empty string.

beckyjackson commented 3 years ago

@jamesaoverton can you please try out the main make test and see if it passes for you?