search

ontohgis / ontology

0 stars 1 forks source link

Remove top adm unit types #5

Closed bszady closed 1 year ago

bszady commented 1 year ago

1) Removal of top-level administrative types represented by 'isSymboliseByMeansOf' map_symbol_100. Except for: administrative_type_57, 135, 143. 2) Example of label change for administrative types (111, 112, 113) that are represented by 'administrative_system_19'. 3) Example of label change for administrative type 246.

bszady commented 1 year ago

There is nothing particularly wrong with this review. Still I would like to see the top-level administrative units to return as individuals - without them one the most substantial distinctions in this ontology will disappear.

I have tried to add an indivudual for Holy Roman Empire. I have made the commit, but I can't to make a push. I have a warning: $ git push To https://github.com/ontohgis/ontology.git ! [rejected] remove_top_adm_unit_types -> remove_top_adm_unit_types (non-fast-forward) error: failed to push some refs to 'https://github.com/ontohgis/ontology.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.

bszady commented 1 year ago

I can't uderstand why I have an info: $ git status On branch remove_top_adm_unit_types Your branch and 'origin/remove_top_adm_unit_types' have diverged, and have 1 and 1 different commits each, respectively. (use "git pull" to merge the remote branch into yours) nothing to commit, working tree clean

bszady commented 1 year ago

I have added one commit with top-level administrative system as individual (no 49). And I added a dcterms::isPartOf between administrative_system_7 and administrative_system_49.