ontologyportal / sigmakee

Sigma Knowledge Engineering Environment
GNU General Public License v3.0
100 stars 34 forks source link

Inline short-living variables of `collectArgFromFormulas` #85

Closed kharus closed 1 year ago

kharus commented 1 year ago

Set produced by collectArgFromFormulas is mostly iterated immediately in for loops apart from few places. This change converts one iteration of collectArgFromFormulas into foreach. And removes temp vars and moves usage of collectArgFromFormulas directily into foreach like in other places. Also forms argument generalized from ArrayList to List.

apease commented 1 year ago

I like removing iterators. I'm not sure about incorporating the calls to produce a list into the foreach. It seems that might have an impact on making debugging more difficult