search

ontologyportal / sigmakee

Sigma Knowledge Engineering Environment
https://www.ontologyportal.org
GNU General Public License v3.0
103 stars 35 forks source link

TPTP output produced twice in SUMOKBtoTPTPKB.main #96

Closed kharus closed 1 year ago

kharus commented 1 year ago

calling SUMOKBtoTPTPKB.main produces tptp file 2 times. First time as SUMO.tptpt in KBmanager#initializeOnce() KBmanager#initializeOnce(java.lang.String):710 KBmanager#loadKBforInference:460 com.articulate.sigma.KB#loadVampire

And second time in SUMOKBtoTPTPKB.main itself.

There are guards to prevent file generation in KB#loadVampire https://github.com/ontologyportal/sigmakee/blob/2b3f14eef0b0c762c6e6491421016dd4fec66b4b/src/java/com/articulate/sigma/KB.java#L3463

But for fresh checkout in SUMO CI they will be true so loadVampire will go ahead and produce the tptp file.

loadVampire is called in a few places. I'm not too sure what would be the best way to avoid generation of file in loadVampire

kharus commented 1 year ago

Please ignore I found a flag to disable KB#loadVampire in KB.loadKBforInference

https://github.com/ontologyportal/sigmakee/blob/2b3f14eef0b0c762c6e6491421016dd4fec66b4b/src/java/com/articulate/sigma/KBmanager.java#L457