ontologyportal / sumo

Suggested Upper Merged Ontology (SUMO)
227 stars 71 forks source link

Redefining VocalCords in terms of VocalCord #211

Closed nordlow closed 4 years ago

nordlow commented 4 years ago

I suggest changing the definition of VocalCords via a new VocalCord defined as

(subclass VocalCord Organ)
(documentation VocalCord EnglishLanguage "A &%VocalCord is a
mucous membrane stretched horizontally across the larynx. They
vibrate, modulating the flow of air being expelled from the lungs
during &%Vocalizing. ")

(=>
  (instance ?VOCAL Vocalizing)
  (exists (?CORD1 ?CORD2 ?ORGANISM)
    (and
      (instance ?CORD1 VocalCord)
      (instance ?CORD2 VocalCord)
      (instrument ?VOCAL ?CORD1)
      (instrument ?VOCAL ?CORD2)
      (not (equal ?CORD1 ?CORD2))
      (part ?CORD1 ?ORGANISM)
      (part ?CORD2 ?ORGANISM)
      (instance ?ORGANISM Organism))))

and then define VocalChords as previously

(typicalPart VocalCords Human)
(typicallyContainsPart VocalCords Human)
(initialPart VocalCords Human)

together with an axiom for VocalCords defining it as a pair of VocalCords. What should that axiom look like?

I presume Lung, Arm, Leg etc should undego the same refactoring/extension.

For more compact encoding it might be useful to define a set of variants of typicalPart and typicallyContainsPart and initialPart that expresses the number of initial parts, in this case two Lungs, VocalCords, etc.

apease commented 4 years ago

Leg, Arm and Lung are already singular, although it looks like we don't have an axiom to say that people typically have two of each. Would you like to try writing the axioms for that? For VocalCords they only work in pairs so I think we should keep the term as is and define VocalCord as a typicalPart. Would you like to try that alternate version?

ArtificialMarty commented 4 years ago

Just a quick nit: in the documentation string for VocalCord, there should be no comma after "The vocal cords".

I can't help it: Mom was an English teacher....

Marty

On Mon, Feb 3, 2020 at 7:16 AM Per Nordlöw notifications@github.com wrote:

I suggest changing the definition of VocalCords to instead first defined VocalCord as

(subclass VocalCord Organ) (documentation VocalCord EnglishLanguage "The vocal cords, are composed of two folds of mucous membrane stretched horizontally across the larynx. They vibrate, modulating the flow of air being expelled from the lungs during &%Vocalizing. ")

(=> (instance ?VOCAL Vocalizing) (exists (?CORD1 ?CORD2 ?ORGANISM) (and (instance ?CORD1 VocalCord) (instance ?CORD2 VocalCord) (instrument ?VOCAL ?CORD1) (instrument ?VOCAL ?CORD2) (not (equal ?CORD1 ?CORD2)) (part ?CORD1 ?ORGANISM) (part ?CORD2 ?ORGANISM) (instance ?ORGANISM Organism))))

and then define VocalChords as previously

(typicalPart VocalCords Human) (typicallyContainsPart VocalCords Human) (initialPart VocalCords Human)

together with an axiom for VocalCords defining it as a pair of VocalCords. What should that axiom look like?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ontologyportal/sumo/issues/211?email_source=notifications&email_token=ADTOVGS72WFTBZBCQ3H73N3RBADKVA5CNFSM4KPEFXD2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKSL25Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTOVGQP4I6PNLK5MNGA44DRBADKVANCNFSM4KPEFXDQ .

apease commented 4 years ago

thanks @ArtificialMarty - the fix will appear next time I pushed more substantial updates to git

apease commented 4 years ago

added notion of VocalFolds and axioms stating that healthy organisms have pairs of several things. A more complete inventory of these things is needed