search

ontop / dialect-factory-scaffolding

Scaffolding tool to simplifying the implementation of a new dialect adapter for Ontop
Apache License 2.0
1 stars 0 forks source link

serializeDateTimeNorm -> serializeDateTimeNormWithTZ #1

Open stefanbischof opened 8 months ago

stefanbischof commented 8 months ago

The method serializeDateTimeNorm is no longer an abstract method of AbstractSQLDBFunctionSymbolFactory, instead there is the method serializeDateTimeNormWithTZ which has to be overridden. Is there anything else needed besides changing the method name and TODO-SCAFFOLD comment?

https://github.com/ontop/dialect-factory-scaffolding/blob/0bf5631357ae0d8a29d5bc2c193c8e46abfa269b/skeleton/db/rdb/src/main/java/it/unibz/inf/ontop/model/term/functionsymbol/db/impl/%7Bpascalname%7DDBFunctionSymbolFactory.java#L134

bcogrel commented 8 months ago

Hi @stefanbischof, thanks for pointing it. Yes, that's should be enough.