TMAPI TestTopicMerge fails

[GoogleCodeExporter]

Test case:
http://tmapi.svn.sourceforge.net/viewvc/tmapi/trunk/src/test/java/org/tmapi/core
/TestTopicMerge.java?revision=87

    [junit] Testcase:
testDuplicateDetectionReifierMerge(org.tmapi.core.TestTopi
cMerge):        FAILED
    [junit] expected:<3> but was:<4>
    [junit] junit.framework.AssertionFailedError: expected:<3> but was:<4>
    [junit]     at
org.tmapi.core.TestTopicMerge.testDuplicateDetectionReifierMe
rge(TestTopicMerge.java:194)
    [junit]
    [junit]
    [junit] Testcase:
testDuplicateSuppressionName2(org.tmapi.core.TestTopicMerg
e):     FAILED
    [junit] expected:<1> but was:<0>
    [junit] junit.framework.AssertionFailedError: expected:<1> but was:<0>
    [junit]     at
org.tmapi.core.TestTopicMerge.testDuplicateSuppressionName2(T
estTopicMerge.java:269)
    [junit]
    [junit]
    [junit] Testcase:
testDuplicateSuppressionNameMoveItemIdentifiers(org.tmapi.
core.TestTopicMerge):   FAILED
    [junit] expected:<2> but was:<1>
    [junit] junit.framework.AssertionFailedError: expected:<2> but was:<1>
    [junit]     at
org.tmapi.core.TestTopicMerge.testDuplicateSuppressionNameMov
eItemIdentifiers(TestTopicMerge.java:296)
    [junit]
    [junit]
    [junit] Testcase:
testDuplicateSuppressionOccurrenceMoveItemIdentifiers(org.
tmapi.core.TestTopicMerge):     FAILED
    [junit] expected:<2> but was:<1>
    [junit] junit.framework.AssertionFailedError: expected:<2> but was:<1>
    [junit]     at
org.tmapi.core.TestTopicMerge.testDuplicateSuppressionOccurre
nceMoveItemIdentifiers(TestTopicMerge.java:344)
    [junit]

Original issue reported on code.google.com by lars.he...@gmail.com on 8 Jul 2009 at 12:15

[GoogleCodeExporter]

Possibly a merging algorithm issue, c.f. issue #28

Original comment by lars.he...@gmail.com on 8 Jul 2009 at 12:20

• Added labels: Component-Engine

[GoogleCodeExporter]

testDuplicateDetectionReifierMerge: fails because Ontopia doesn't merge 
reifiers 
when what they reify is merged. That's an Ontopia engine issue, not an issue in 
the 
TMAPI 2.0 implementation.

testDuplicateSuppressionName2: fails because although Ontopia merges the names 
it 
does not merge the variants. This is also an Ontopia issue, and not an issue in 
the 
TMAPI 2.0 implementation.

testDuplicateSuppressionNameMoveItemIdentifiers: fails because although Ontopia 
merges the names it does not merge the item identifiers. Also an Ontopia issue.

testDuplicateSuppressionOccurrenceMoveItemIdentifiers: same as above.

I suggest that I take over this one and fix the underlying problems in Ontopia, 
and 
then we see if that solves the problems.

Original comment by lar...@gmail.com on 8 Jul 2009 at 1:44

[GoogleCodeExporter]

Would be great if we convert these tests into CXTM tests

Original comment by lars.he...@gmail.com on 8 Jul 2009 at 1:56

[GoogleCodeExporter]

We should have CXTM tests for these as well, I agree. I can make those at the 
same 
time as I go through these and add Ontopia tests for them.

Original comment by lar...@gmail.com on 8 Jul 2009 at 8:01

[GoogleCodeExporter]

Original comment by lar...@gmail.com on 16 Jul 2009 at 10:52

• Changed state: Started

[GoogleCodeExporter]

Have solved three of the four in my working copy now, while really working on 
issue 
77. Still quite a bit of work needed before I get the codebase to a point where 
I 
can check in.

Original comment by lar...@gmail.com on 16 Jul 2009 at 11:04

[GoogleCodeExporter]

Three of these were caused by errors in the underlying Ontopia merging code, 
but 
testDuplicateSuppressionName2 appears to be caused by a bug in NameImpl. It 
seems 
that the cached set of variant objects in NameImpl is not kept in sync with the 
underlying objects in all cases. 

So this is actually a bug in the TMAPI 2.0 code as far as I can see. Therefore 
moving the issue to Hannes.

Original comment by lar...@gmail.com on 16 Jul 2009 at 1:12

[GoogleCodeExporter]

It seems the varient problem was the reason for all the failures.

Original comment by h.niederhausen@googlemail.com on 16 Jul 2009 at 3:16

[GoogleCodeExporter]

This issue was closed by r330.

Original comment by h.niederhausen@googlemail.com on 16 Jul 2009 at 3:17

• Changed state: Fixed