search

ontoportal-lirmm / bioportal_web_ui

A Rails application for ontologies portal.
http://agroportal.lirmm.fr/
Other
6 stars 5 forks source link

Fix: Watch button count and state #838

Closed Bilelkihal closed 2 weeks ago

Bilelkihal commented 2 weeks ago

Related issue: https://github.com/ontoportal-lirmm/bioportal_web_ui/issues/819

Source of issue To get the subscriptions of a user we used to the the call with the param ?include=subscription which used to display the users with their subscription list that includes ontologies acronyms, but after idk what we did in the back side the same call gives us a result like this one

image

The solution is to do include=all and this is the result of it

image

Demo

https://github.com/user-attachments/assets/618f2f88-4a06-4e1a-b40d-932540b5ecc1

syphax-bouazzouni commented 2 weeks ago

But seems that tests are not passing ? @Bilelkihal

Bilelkihal commented 2 weeks ago

Good job on fixing that, can you open an issue in the API repo, so that we fix also in the back someday,

Done: https://github.com/ontoportal-lirmm/ontologies_api/issues/108

Bilelkihal commented 2 weeks ago

But seems that tests are not passing ? @Bilelkihal

Errors not related to this PR, I think that they are already in the dev branch, I need to fix them in a separate PR and merge it