ontoportal-lirmm / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
0 stars 6 forks source link

Migrate the submission metrics attributes to Metrics model #77

Closed syphax-bouazzouni closed 10 months ago

syphax-bouazzouni commented 1 year ago

Context

In the 2018 iteration of work in the submission metamodel, we copied a bunch of attributes from the metrics model into the submission model. Below is a comparison between the two models

Metrics model Submission metrics
classes numberOfClasses
individuals numberOfIndividuals
properties numberOfProperties
maxDepth maxDepth
maxChildCount maxChildCount
averageChildCount averageChildCount
classesWithOneChild classesWithOneChild
classesWithMoreThan25Children classesWithMoreThan25Children
classesWithNoDefinition classesWithNoDefinition
  numberOfAxioms
  entities

Requirements

[
  {
  "numberOfAxioms": 23601,
  "entities": null,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/OM/submissions/16"
  },
  {
  "numberOfAxioms": 10381,
  "entities": 709,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/CROPUSAGE/submissions/17"
  },
  {
  "numberOfAxioms": 35486931,
  "entities": null,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/TAXREF-LD/submissions/4"
  },
  {
  "numberOfAxioms": 742,
  "entities": null,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/IRRIG/submissions/1"
  },
  {
  "numberOfAxioms": 4931,
  "entities": null,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/SFWO/submissions/5"
  },
  {
  "numberOfAxioms": 100,
  "entities": 10,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/PIZZA2/submissions/1"
  },
  {
  "numberOfAxioms": 1689,
  "entities": 335,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/OWSD/submissions/1"
  },
  {
  "numberOfAxioms": 49,
  "entities": null,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/PPDO/submissions/5"
  },
  {
  "numberOfAxioms": 433,
  "entities": null,
  "@id": "https://data.agroportal.lirmm.fr/ontologies/CASO/submissions/5"
  }
]
syphax-bouazzouni commented 1 year ago

done in https://github.com/ontoportal-lirmm/ontologies_linked_data/pull/72/commits/1b3fb6814c0ca242bc8c0842375f9f898d6365b9

image
syphax-bouazzouni commented 1 year ago

do you think it's good @jonquet . Or do we need that those attributes are called the same as before (numberOfClasses, numberOfIndividuals, numberOfProperties)

jonquet commented 1 year ago

No need to change the names of those properties as they are the ones used by default in OntoPortal.

syphax-bouazzouni commented 10 months ago

Close a done