Code review committee

[syphax-bouazzouni]

The Goal

Having the committee and process set up allows us to consider issues in a way everyone has agreed is fair, so people don’t feel like we’re just making it up as we go along.

Propositions

• [ ] Define a default practice of the number of people to review any code submission and, who is required for what (A)
• [ ] a list of any coding or other practices we expect to require on OntoPortal (B);
• [ ] a group of people who serve as referees (C) for fundamental decisions about the acceptability of significant changes
• [ ] Alternatively, designate a voter from each public portal. Not everyone has to vote on every issue; (D)

[graybeal]

Highly support this.

For the first item (A), I propose as a default that a one person from the following list should be required to review/approve OntoPortal code submissions, and that at least one other developer from any OntoPortal repository should be required to review/approve submissions.

• Syphax; Jennifer; Misha; others as agreed by existing members. (Criteria are: wide experience with OntoPortal code; general awareness of agreed best practices, OntoPortal community software and active developments.)

I also suggest for the first item (A), or a separate item, that resolution of other tickets (not involving code or configuration changes) should also be reviewed by at least one technical leader (Tim, Clement, John, …), as well as one other person with knowledge of the specific domain. But review by the same person as already indicated would be OK too.

For item C (which I think is more about evaluating whether the addition of the feature makes OntoPortal better from the community or not as good for the community): I think this group should include one person chosen by each willing OntoPortal team to represent their team. Ideally it's either a PI (Mark or John, Clement, etc) or a senior developer or team leader (advised by the PI and rest of the team). Ideally decisions require consensus or at least 75% of active voters. It's up to each team that wants to participate in this evaluation to designate the voting member. (This approach essentially incorporates the last bullet (D).)

As soon as the teams in (A) and (C) are established, anyone could bring a 'recommended practice' (B) forward for evaluation by creating a ticket, approvable by a vote of 75% of the members of (A) and (C).

[jonquet]

I think a committee and the mechanisms in (A) and (C) are relevants if we do find the right balance between progress and decisions making. We also need a bit of flexibility considering the OntoPortal Alliance is based on volunteering and not each group would have a representative (or simply just time and/or motivation) for participating in committees.