search

onur-ozkan / nestjs-rate-limiter

Highly configurable and extensible rate limiter library
https://npmjs.com/package/nestjs-rate-limiter
MIT License
238 stars 43 forks source link

feat(interceptor): add fastify support to set headers #11

Closed acal11 closed 4 years ago

acal11 commented 4 years ago

Added a header-set check to support fastify

acal11 commented 4 years ago

Found that the interceptor does not execute if guards are being used in the application which deny a request, therefore I created a guard version of the interceptor. There is no breaking change here.

kevinsproles commented 4 years ago

I also need this: specifically the guard rather than the interceptor.

@ozkanonur can we merge this in?

Andre-InfoTrack commented 4 years ago

I also need this: specifically the guard rather than the interceptor.

@ozkanonur can we merge this in?

I created a fork of this repo back before it got a new maintainer which includes the interceptor, you can look into that if it doesn't get merged.

onur-ozkan commented 4 years ago

I also need this: specifically the guard rather than the interceptor.

@ozkanonur can we merge this in?

What is the reason ? I can't merge this, there are so many things that have been changed.

kevinsproles commented 4 years ago

Because I'd like my rate limiter to execute first, before the guards.

1) To mitigate brute force attacks on the guards. 2) To mitigate overwhelming the authentication layer.