search

onur / acme-client

Yet another Let's Encrypt client and library written in Rust.
MIT License
225 stars 33 forks source link

same parameter name for USER_KEY #21

Closed benaryorg closed 6 years ago

benaryorg commented 6 years ago

It was named USER_KEY in the argument list but used as USER_KEY_PATH. The _PATH suffix probably originates from the same parameter for the sign subcommand, which doesn't make sense here though as it only handles the revocation.

A more elaborate fix would be to name everything similarly, but that has a higher chance of introducing breakage.

onur commented 6 years ago

Thanks! How did I miss that one, nice catch!