Open miszo opened 3 years ago
Hello @miszo, Thanks for your support! We are open to all kinds of contributions.
I know too many parameters is not best case but I could not decide how I solve this. If you want to make PR for this issues, I would be very pleased.
Hi @onurzorluer, I hope that I get some time this weekend to do it. I'll send you a PR with this issues addressed :)
@onurzorluer vscode has a quick action for doing exactly that refactor BTW.
Hi @onurzorluer, for starters I would like to thank you for the lovely library π
Is your feature request related to a problem? Please describe. I have two issues that I would like to address and can even create a PR with it π
imageSizeResizer
method has too many parameters, and it's not the best developer experience you can imagine.Describe the solution you'd like
imageSizeResizer
to take one object argument. It would be easier for developers to use it because they wouldn't need to check the order of the arguments that they need to pass. The exported method would look like this:Please let me know what do you think about the solutions and my contribution towards it.