search

onurzorluer / react-image-file-resizer

Resize Local Images with React 🌄 🌅
MIT License
313 stars 41 forks source link

**BREAKING CHANGE** OPTIONAL MAX WIDTH / HEIGHT #67

Closed MattyPalka closed 1 year ago

MattyPalka commented 2 years ago

BREAKING CHANGE OPTIONAL MAX WIDTH / HEIGHT

thany commented 2 years ago
  1. It'd be better to change it to requiring an options object with all the required and optional parameters in there. That would be the kind of breaking change that is much more future-proof.
  2. Changing to let/const should not be within the scope of such a change.

(I'm not the author btw, just another concerned user)

MattyPalka commented 2 years ago

@thany yeah I completely agree with you to have options object, but it was too many changes, so I just created my wrapper on top of this implementation :)

donavon commented 1 year ago

Changing to let/const should not be within the scope of such a change.

Changing from var to const should always be in scope ;)

💯 on the options object. I couldn't believe the number of parameters!