Add a generic icon function that can return icons from all supported sets - Githubissues

onvardgmbh / inline-svg

MIT License

1 stars 2 forks source link

Add a generic icon function that can return icons from all supported sets #4

Open ght opened 5 years ago

ght commented 5 years ago

Current behavior

If support for multiple icon sets is wanted, it is necessary for the code to handle this at each call site, e.g. like this:

@if (!empty($fontawesome)) // e.g. 'calendar'
  {!! \Onvardgmbh\InlineSVG::fontawesome($fontawesome)->get() !!}
@elseif (!empty($ionicon)) // e.g. 'attach'
  {!! \Onvardgmbh\InlineSVG::ionicons($boxicon)->get() !!}
@elseif (!empty($boxicon)) // e.g. 'bx-map'
  {!! \Onvardgmbh\InlineSVG::boxicons($boxicon)->get() !!}
@endif

Desired behavior

It should be possible to use icons from all supported sets, without the code at the call site even knowing which sets exist.

A possible implementation could be used like this (comments welcome):

@if (!empty($icon)) // e.g. 'fa/calendar', 'ion/attach', 'box/bx-map'
  {!! \Onvardgmbh\InlineSVG::icon($icon) !!}}
@endif

Pros

template code much simpler
supporting all icon sets, even in code that was written before an icon set is added to this library, is trivial
icon identifiers contain the which set they are from directly and are not ambiguous, e.g. 'fa/search' and 'ion/search' vs. now only 'search'
should be easy to implement (split parameter at first '/', pick one of the other functions depending on what is before the '/' and pass everything after on as parameter)

bjoernhasse commented 5 years ago

Agree :+1:

Furthermore we then should add a unified method for returning the options (getOptionsFontAwesome, getOptionsIonicons, getOptionsBoxicon.) The new getOptions method should return the icon options in the new 'ion/attach' format.