search

onvif / specs

ONVIF Network Interface Specifications
Other
338 stars 90 forks source link

Use empty ICE candidate to indicate done sending candidates #398

Closed MaximeBdrd closed 5 months ago

MaximeBdrd commented 7 months ago

Add an additional notification message to the WebRTC flow that has to be sent after a peer sends its last ICE candidate. It contains the total number for ICE candidates sent by this peer so that the other peer will know it received everything even when reception is out of order. It is useful for a peer to know it received all the candidates for candidate pair selection and troubleshooting.

jflevesque-genetec commented 6 months ago

As discussed during the F2F in Puerto Rico, updated the PR to instead use an empty ICE candidate to indicate that a peer is done sending its candidate.

Note: ICE candidates are expected to be received in order.

HansBusch commented 6 months ago

Suggest to refer to RFC 8838 regarding end-of-candidates. Also suggest to keep candidates element mandatory but require to send empty content. Otherwise it is unclear whether to send empty content or leave out.

Not sure whether this needs normative text as everything is well defined in RFC 8838.