search

onvif / specs

ONVIF Network Interface Specifications
Other
344 stars 93 forks source link

User roles proposal #454

Open ocampana-videotec opened 3 months ago

ocampana-videotec commented 3 months ago

Initial proposal for implementing editable user levels. They are necessary for SOAP over SCTP in WebRTC sessions.

jflevesque-genetec commented 3 months ago

Is it possible not to include whitespace changes or similar changes in the PR? It makes it terribly difficult to find the actual changes in the documents. If its a clean up we want, we should do that change in a separate PR so it can be accepted quickly so future changes include them by default.

kieran242 commented 1 month ago

Is it possible not to include white-space changes or similar changes in the PR? It makes it terribly difficult to find the actual changes in the documents. If its a clean up we want, we should do that change in a separate PR so it can be accepted quickly so future changes include them by default.

I do agree with this comment there was a lot in this PR not related to the topic that was highlighted as changed. I do not believe ether that it was deliberate.

I choose in this instance to identify grammar or spelling mistakes that the opportunity presented for correction and highlight them as suggestions for update and fix that should improve the quality of the final specifications.