onweru / hugo-swift-theme

A simple open source theme for publishing with hugo
https://neuralvibes.com/
Other
120 stars 64 forks source link

Post thumbnail display broken on Hugo Themes demo #37

Closed VincentTam closed 5 years ago

VincentTam commented 5 years ago

Screenshot_2019-08-14_15-54-43

https://themes.gohugo.io/theme/hugo-swift-theme

onweru commented 5 years ago

I have noticed this for a while now. For some reason .Params.image isn't resolved on the demo (check source).

I can't say that I have found a theme that implements images in previews well. But then I haven't been thorough in my search.

onweru commented 5 years ago

@VincentTam, have you noticed the following about the theme's demo:

  1. There are post duplicates
  2. The demo doesn't read from the exampleSite directory of this theme. For instance, if you look closely, you won't find an article titled emoji support anywhere in the aforementioned directory 🤔

If the above observation are in fact true:

onweru commented 5 years ago

@VincentTam, have you noticed the following about the theme's demo:

  1. There are post duplicates
  2. The demo doesn't read from the exampleSite directory of this theme. For instance, if you look closely, you won't find an article titled emoji support anywhere in the aforementioned directory 🤔

If the above observation are in fact true:

  • I cannot immediately explain (1) above
  • (2) above would explain why the image thumbnails are broken on the demo.

Aha, it's all explained here. Specifically in this paragraph

If your theme doesn’t fit into the Hugo Basic Example site, we encourage theme authors to supply a self-contained Hugo site in /exampleSite/, but note that for security reasons the content directory on the Hugo showcase will still be published from the Hugo Basic Example repository.

Thusly, I would not consider this issue eligible for a wont-fix

VincentTam commented 5 years ago
  1. There are post duplicates

@onweru Refer to item 3 in https://github.com/gohugoio/hugoThemes/issues/665#issuecomment-517635357.

onweru commented 5 years ago
  1. There are post duplicates

@onweru Refer to item 3 in gohugoio/hugoThemes#665 (comment).

It seems that this issue disappeared overnight

VincentTam commented 5 years ago

@onweru Thanks for update.