search

onweru / newsroom

A simple, minimalistic Hugo theme. View Demo here
https://rooms.netlify.app/
Other
287 stars 114 forks source link

dark mode as default #43

Closed anibal-aguila closed 1 year ago

anibal-aguila commented 2 years ago

Hi, great work! There are some way to have dark mode as default,

Thanks in advance,

jmooring commented 2 years ago

Related: https://github.com/onweru/newsroom/issues/3

onweru commented 2 years ago

@anibal-aguila, this feature doesn't exist currently. Will add soon

anibal-aguila commented 2 years ago

Hi @onweru I add it, hope it's ok.

https://github.com/onweru/newsroom/pull/44

Please close this issue if you think it's done.

Regards,

jmooring commented 2 years ago

RE: #44:

No.

There are two different capabilities to consider:

  1. Setting the default mode to either light or dark, and allow the user to switch between them. The mode must be sticky as the user navigates the site.
  2. Disallow mode switching.
onweru commented 2 years ago

@jmooring is absolutely right. I have implemented it before in the compose theme, so I just need time carry over the same here.

onweru commented 1 year ago

I think this is now settled after be27fd3dcca7f338765ebd2bc8abb45d69fc13c4. The change is of course backward compatible.