lbradstreet
commented
7 years ago Thanks for the fix! I’ll review it tomorrow and release a new version.
Cheers,
Lucas
On 29 Sep 2017, at 11:17, Jeremie Pelletier notifications@github.com wrote:
Hello!
We're starting to use the S3 plugin on buckets with large quantities of objects and noticed it doesn't handle truncated results correctly; the code keeps sending the same query over and over.
I also noticed there's a new V2 API to list S3 objects, but left the V1 implementation in place to keep the fix simple.
You can view, comment on, or merge this pull request online at:
https://github.com/onyx-platform/onyx-amazon-s3/pull/11
Commit Summary
Fix infinite loop in onyx.plugin.s3-utils/list-keys File Changes
M src/onyx/plugin/s3_utils.clj (20) Patch Links:
https://github.com/onyx-platform/onyx-amazon-s3/pull/11.patch https://github.com/onyx-platform/onyx-amazon-s3/pull/11.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Hello!
We're starting to use the S3 plugin on buckets with large quantities of objects and noticed it doesn't handle truncated results correctly; the code keeps sending the same query over and over.
I also noticed there's a new V2 API to list S3 objects, but left the V1 implementation in place to keep the fix simple.