search

onyx-platform / onyx

Distributed, masterless, high performance, fault tolerant data processing
http://www.onyxplatform.org
Eclipse Public License 1.0
2.05k stars 205 forks source link

Re-enable window crash test #458

Closed MichaelDrogalis closed 8 years ago

MichaelDrogalis commented 8 years ago

@lbradstreet I disabled the intermittently failing assertion until we can look into it. For now I need to make sure the build is green for the specific work I'm doing as I'm pushing a lot of other unrelated patches.

MichaelDrogalis commented 8 years ago

Closing, this test wasn't particularly strong to begin with, and it's now being covered by Jepsen.

lbradstreet commented 8 years ago

Yup, there are quite a few crash related tests in the plugins that I'd like to get rid of too. They were only a stop gap for our Jepsen work. :+1

lbradstreet commented 8 years ago

@MichaelDrogalis, I wonder if this was introduced by the code that broke https://github.com/onyx-platform/onyx/issues/504. I'm tempted to leave this test in as it's an early sanity check on whether we can recover state. It's quite a bit quicker to debug via cycles of this test than jepsen.

The main downside I see in keeping it in, is that it's rather slow. This could be resolved by creating a slow-test test selector.

By the way, the test is still in develop?