search

onyx-platform / onyx

Distributed, masterless, high performance, fault tolerant data processing
http://www.onyxplatform.org
Eclipse Public License 1.0
2.05k stars 205 forks source link

Clojure 1.10 fixes #884

Closed solatis closed 5 years ago

solatis commented 5 years ago

With Clojure 1.10 being released, there were two additional namespace issues that this PR resolves. This makes Onyx fully compatible with Clojure 1.10.

lbradstreet commented 5 years ago

Thanks! I’ll get a release out soon

jsab commented 5 years ago

Any ETA for that release @lbradstreet ?

lbradstreet commented 5 years ago

@jsab was this not covered by 0.14.1? 0.14.1 included the fixes from this PR. If not, another PR may be required.

jsab commented 5 years ago

@lbradstreet See https://github.com/onyx-platform/onyx/blob/0.14.x/src/onyx/state/serializers/windowing_key_decoder.clj#L3 (permalink)

Fix is not in 0.14.x.

However it is in master: https://github.com/onyx-platform/onyx/blob/master/src/onyx/state/serializers/windowing_key_decoder.clj#L3 (permalink)

another PR may be required.

A PR from master to 0.14.x ?

solatis commented 5 years ago

I can confirm that this patch is not yet released in 0.14.1. I think that release did include a patch from @puredanger , but there were a few additional modifications required for full clojure 1.10 support.

lbradstreet commented 5 years ago

Thanks, I may just have to make another release then. I’ll find out what went wrong.

Cheers

Lucas

On 6 Feb 2019, at 22:01, Jean-Sebastien A. Beaudry notifications@github.com wrote:

@lbradstreet See https://github.com/onyx-platform/onyx/blob/0.14.x/src/onyx/state/serializers/windowing_key_decoder.clj#L3 (permalink)

Fix is not in 0.14.x.

However it is in master: https://github.com/onyx-platform/onyx/blob/master/src/onyx/state/serializers/windowing_key_decoder.clj#L3 (permalink)

another PR may be required.

A PR from master to 0.14.x ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

lbradstreet commented 5 years ago

Ah, ok that makes sense. Thanks!

On 6 Feb 2019, at 22:01, Jean-Sebastien A. Beaudry notifications@github.com wrote:

@lbradstreet See https://github.com/onyx-platform/onyx/blob/0.14.x/src/onyx/state/serializers/windowing_key_decoder.clj#L3 (permalink)

Fix is not in 0.14.x.

However it is in master: https://github.com/onyx-platform/onyx/blob/master/src/onyx/state/serializers/windowing_key_decoder.clj#L3 (permalink)

another PR may be required.

A PR from master to 0.14.x ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jsab commented 5 years ago

@lbradstreet Sorry to bother you about this but any progress with the release?

lbradstreet commented 5 years ago

@jsab sorry about that. I'm unable to spend much time on maintaining onyx these days.

I've cut 0.14.2. Assuming it makes its way through the build system successfully, it should be ready for use soon.

lbradstreet commented 5 years ago

Resolved by onyx 0.14.4.

jsab commented 5 years ago

Big thanks, I can confirm 0.14.4 is working with clojure 1.10.