search

onyxbits / remotekeyboard

Android input method
http://www.onyxbits.de/remotekeyboard
Apache License 2.0
110 stars 25 forks source link

IP addresses && scrollable main activity #6

Closed denilsonsa closed 10 years ago

denilsonsa commented 10 years ago

I've been hacking RemoteKeyboard code. I've implemented two things:

  1. Showing all IP addresses at the main activity.
  2. Showing one IPv4 address at the notification area.
  3. Making the main activity layout scrollable.

Since when I started hacking the code, I see you have already implemented the second item from this list. Well, you may want to look at my changes anyway. Bear with me, as I have almost zero Android and Java experience.

onyxbits commented 10 years ago

Hi, I'll have to reject that pull request:

  1. That's precisely what I don't want to do and one of the things that already pissed me off with WIFI Keyboard. You have to take the technically illiterate user into account here. Finding and starting a telnet client is often already a problem for them. Throw half a dozen IP addresses at them and telling them "pick one" is not going to help the situation (especially if they start with the IPv6 one and their telnet client does not speak IPv6).
  2. Already did that myself
  3. I'll add that myself, less trouble than fishing it out of the commit.

Am Mittwoch, den 02.10.2013, 07:40 -0700 schrieb Denilson Figueiredo de Sá:

I've been hacking RemoteKeyboard code. I've implemented two things:

 1. Showing all IP addresses at the main activity.
 2. Showing one IPv4 address at the notification area.
 3. Making the main activity layout scrollable.

Since when I started hacking the code, I see you have already implemented the second item from this list. Well, you may want to look at my changes anyway. Bear with me, as I have almost zero Android and Java experience.

You can merge this Pull Request by running git pull https://github.com/denilsonsa/remotekeyboard hacking

Or view, comment on, or merge it at:

https://github.com/onyxbits/remotekeyboard/pull/6

Commit Summary * Rewriting the code that shows the IP address. * Making the main activity layout scrollable. File Changes * M res/layout/activity_main.xml (71) * M res/values/strings.xml (6) * M src/de/onyxbits/remotekeyboard/MainActivity.java (46) * M src/de/onyxbits/remotekeyboard/RemoteKeyboardService.java (11) Patch Links: * https://github.com/onyxbits/remotekeyboard/pull/6.patch * https://github.com/onyxbits/remotekeyboard/pull/6.diff

denilsonsa commented 10 years ago

Okay, that's fine, no problem!