search

onyxframework / onyx

Powerful framework for modern applications 💪
https://api.onyxframework.com/onyx
MIT License
78 stars 5 forks source link

The assert of response should not always be true #20

Closed shootingfly closed 5 years ago

shootingfly commented 5 years ago

https://github.com/onyxframework/onyx/blob/d51591b22cf97924d2bc5d611e146309250da168/src/onyx/http/spec.cr#L83-L86

Because the parameter name is the same as the method name, the assert always be true.

Example. https://play.crystal-lang.org/#/r/6v7p

vladfaust commented 5 years ago

That's a bug! 🐛