Closed vladfaust closed 5 years ago
in spec/bulk_query/delete_spec.cr:8: missing argument: rs Overloads are: - Onyx::SQL::Serializable.new(rs : DB::ResultSet, stop_column : String | ::Nil = nil, column_indexer = ColumnIndexer.new) user1 = User.new(uuid: uuid1)
Whereas Onyx::SQL::Serializable.new is protected:
Onyx::SQL::Serializable.new
protected
https://github.com/onyxframework/sql/blob/c197a2267328f073bbcaeb9d75b80f45c5dae844/src/onyx-sql/serializable.cr#L190-L194
And Onyx::SQL::Model.new is not:
Onyx::SQL::Model.new
https://github.com/onyxframework/sql/blob/c197a2267328f073bbcaeb9d75b80f45c5dae844/src/onyx-sql/model.cr#L146
Related: https://github.com/amberframework/granite/issues/337
Fixed in 5c46c6dacb08d266e2e97793ecaac5b91b1248c9. Kudos to @Blacksmoke16! :tada:
Whereas
Onyx::SQL::Serializable.new
isprotected
:https://github.com/onyxframework/sql/blob/c197a2267328f073bbcaeb9d75b80f45c5dae844/src/onyx-sql/serializable.cr#L190-L194
And
Onyx::SQL::Model.new
is not:https://github.com/onyxframework/sql/blob/c197a2267328f073bbcaeb9d75b80f45c5dae844/src/onyx-sql/model.cr#L146