search

oobabooga / text-generation-webui

A Gradio web UI for Large Language Models.
GNU Affero General Public License v3.0
39.41k stars 5.18k forks source link

Dual fp16 / GGUF models not downloaded correctly #5491

Closed PyroGenesis closed 4 months ago

PyroGenesis commented 6 months ago

Describe the bug

When I try to download a model whose repo as both fp16 weights and GGUF files, it incorrectly downloads the model files to the models directory instead of a subfolder.

Is there an existing issue for this?

Reproduction

Try to download defog/sqlcoder-7b-2 leaving specific file as empty

Details

I looked into the code a bit, and maybe this is a '' vs None issue.

download_model_wrapper() passes specific_file='' to downloader.get_download_links_from_huggingface() https://github.com/oobabooga/text-generation-webui/blob/0f134bf744acef2715edd7d39e76f865d8d83a19/modules/ui_model_menu.py#L245-L251

but get_download_links_from_huggingface() checks if specific_file is not None https://github.com/oobabooga/text-generation-webui/blob/0f134bf744acef2715edd7d39e76f865d8d83a19/download-model.py#L155-L157

BTW this wasn't an issue in an older version of text-generation-webui

System Info

OS: Windows Server 2022
github-actions[bot] commented 4 months ago

This issue has been closed due to inactivity for 2 months. If you believe it is still relevant, please leave a comment below. You can tag a developer in your comment.