Closed davidhesselbom closed 8 years ago
By git log -S 2147483647 --source --all
, I find it is introduced here
commit 3d49553721fe803d76c89be06a84f97a91db7ce5
Author: nddrylliog <nddrylliog@gmail.com>
Date: Wed Apr 21 09:59:51 2010 +0200
INT_MIN fixes, Win32 fixes for SdkLocator and Module, MakeDriver improvement (OS/machine detection)
I can't point out the exact reason, but there's no different for me between literal and extern. Maybe the bug has been fixed.
2010! Perhaps back then I was building in an environment lacking INT_MIN
/ a proper limits.h
?
Yeah, I know, it's been a long time! :) So you don't remember making it a literal to prevent some problem related to the system bitness or anything (I doubt you've ever run rock on a 16-bit system, but what do I know)?
Were the comments supposed to replace the literals when you got a proper limits.h
, but then that never happened? And, should it be const static
, and does it matter?
don't remember
Nope! No idea. Maybe I wanted to take the address of INT_MIN
and needed it to be a proper variable.
const static
I'm not sure rock passes const to the C compiler anymore, and static would just confine it to the file afaict?
No, you're right, const
is ignored... alright, well, no harm in changing it then. Thanks!
Fixed by #927.
In
Numbers.ooc
:How come the limits for
Int
are set like this, but the rest areextern
? Is it just something that hasn't been fixed, or is it, in fact, a fix for something?