Improved limit externs in Numbers.ooc.

[davidhesselbom]

I tried to clean this up a little bit, and I also added limits for Short and UShort. I'm guessing you want to redo this your own way, though (formatting etc).

FLT_MIN and DBL_MIN were defined twice for some reason, so I removed the ones that seemed to be in the wrong place.

[fasterthanlime]

Hmm. There's no tests using all of them afaict, how would if they're broken/non-existant ?

[davidhesselbom]

Good question. I guess I add tests in another commit and update the pull request?

[fasterthanlime]

That'd be great, thanks

[davidhesselbom]

How would you like me to test it, though? Compare the extern values to literals containing the expected values?

[fasterthanlime]

I wouldn't compare them, I would just use them, let rock output C files containing those symbols, let a C compiler compile them.

Just referring to them will make the test fail if they're missing/misspelled

[davidhesselbom]

Okay, so you're only worried that they won't exist, not about their actual values?

[fasterthanlime]

Yup. I'm confident that if they exist, they'll have the right values.

[davidhesselbom]

Updated. Would that test do it?

Btw, INFINITY and NAN are still defined as extern Doubles. Not sure what that will mean for an LDouble, but it was already like that, so...

[fasterthanlime]

@davidhesselbom that works, thanks!