Closed davidhesselbom closed 8 years ago
Hmm. There's no tests using all of them afaict, how would if they're broken/non-existant ?
Good question. I guess I add tests in another commit and update the pull request?
That'd be great, thanks
How would you like me to test it, though? Compare the extern values to literals containing the expected values?
I wouldn't compare them, I would just use them, let rock output C files containing those symbols, let a C compiler compile them.
Just referring to them will make the test fail if they're missing/misspelled
Okay, so you're only worried that they won't exist, not about their actual values?
Yup. I'm confident that if they exist, they'll have the right values.
Updated. Would that test do it?
Btw, INFINITY
and NAN
are still defined as extern Double
s. Not sure what that will mean for an LDouble
, but it was already like that, so...
@davidhesselbom that works, thanks!
I tried to clean this up a little bit, and I also added limits for
Short
andUShort
. I'm guessing you want to redo this your own way, though (formatting etc).FLT_MIN
andDBL_MIN
were defined twice for some reason, so I removed the ones that seemed to be in the wrong place.