ArrayList bound checks twice when getting an element

[alexnask]

get: inline func(index: SSizeT) -> T {
        if(index < 0) index = _size + index
        if(index < 0 || index >= _size) OutOfBoundsException new(This, index, _size) throw()
        checkIndex(index)
        return data[index]
    }

    checkIndex: inline func (index: SSizeT) {
        if (index >= _size) {
            OutOfBoundsException new(This, index, _size) throw()
        }
    }

[alexnask]

Removing the checkIndex call seems like the right thing to do, as the negative index needs to be re-checked.

[fasterthanlime]

@shamanas what if index < -_size ?

edit: I can't read. Yeah I guess someone forgot to remove the checkIndex call

[alexnask]

Sure, removing the checkIndex call and leaving the second if is my proposal.

Then, if index < -_size, it is still caught, as well as the index >= _size check that is done twice.

[fasterthanlime]

sounds good