Closed jonathn closed 8 years ago
@davidhesselbom @zhaihj hey look guys, that's why INT_MIN
was a literal.. cf. #926
I suppose a good fix would be to include limits.h
but only on OSX
:-(
I didn't even think about OSX :(
For some reason (4K screenshots and evident OSX compatibility concerns in the SDK, probably) I thought that's what Amos was using anyway. If that's not the case, it might be worth looking into letting Travis run tests for OSX (see http://docs.travis-ci.com/user/osx-ci-environment/), so this type of thing doesn't happen again.
@davidhesselbom I am using OSX, I just didn't try running the changes on it, they seemed pretty simple.
That said, I agree, having an OSX travis setup would be nice. Beware though, OSX support is notably unstable on Travis (builds randomly failing)
Someone with a mac please test adding version(osx) { include limits }
(probably version(apple), I'm not sure what the case is for ios) and open a pull request please.
@shamanas accidentally push-requested instead but it seems to work as well! ;)
Trying to build from git source on macosx 10.9.5, I get the following error when I run 'make rescue':
I have XCode 6.2 installed which comes with the following gcc: $ gcc --version Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1 Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) Target: x86_64-apple-darwin13.4.0 Thread model: posix
I narrowed down the commit that introduced this error to this one: https://github.com/fasterthanlime/rock/commit/287ac783d080715f9336868974d77f1acbbca708