fix a few issues pointed out by cppcheck

[GoogleCodeExporter]

What steps will reproduce the problem?
cppcheck -f .

The patches have been only build tested, please review.

Original issue reported on code.google.com by riccardo...@gmail.com on 5 Apr 2011 at 4:58

Attachments:

• derefence-data-after-check.diff
• free-tmp-layout-on-error.diff
• remember-to-free-exec.diff

[GoogleCodeExporter]

Thanks a lot for the patches, can you post the first two patches on the 
florence project also
http://florence.sourceforge.net

Original comment by al...@paranoici.org on 18 Apr 2011 at 11:41

[GoogleCodeExporter]

The bug is close on the trunk since the subversion revision 2361. The first two 
patches are submitted as is. The function xdg_create_link has been rewritten in 
order to have a good style and to be memory leak free. All the new code is 
reviewed with the cppcheck tool. 

Original comment by al...@paranoici.org on 18 Apr 2011 at 11:50

[GoogleCodeExporter]

The issue is closed

Original comment by al...@paranoici.org on 18 Apr 2011 at 11:50

[GoogleCodeExporter]

Original comment by al...@paranoici.org on 18 Apr 2011 at 11:50

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by al...@paranoici.org on 17 Sep 2012 at 5:16

• Changed state: Verified