search

ooguntola / numexpr

Automatically exported from code.google.com/p/numexpr
MIT License
0 stars 0 forks source link

Missing license files #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please merge patches [1] and [2] that fix a couple of small licenseing issue:

 * missing license file for numexpr/win32/pthread.* [1]
 * the LICENSES directory is not currently included in the source tarball [2]

see also [3].

[1] 
https://code.google.com/r/avalentinoit-numexpr/source/detail?r=e118b0e513ed4cbe9
397bea45499e0d6d4b4fa94
[2] 
https://code.google.com/r/avalentinoit-numexpr/source/detail?r=4602dadb61c2bd052
e0008bcfff4ca5aeef9a52c
[3] 
http://lists.alioth.debian.org/pipermail/debian-science-maintainers/2013-July/01
9344.html

Original issue reported on code.google.com by a.valent...@gmail.com on 13 Jul 2013 at 5:53

GoogleCodeExporter commented 9 years ago 
Hey Antonio,

Yes, numexpr has a problem with the pthread code for Windows compatibility.  I 
have contacted the author a few years ago asking for permission to redistribute 
his code without the GPL, but I never got a response from him (I pinged him 
again; you are in CC).

In case the author would not respond in a decent amount of time we should look 
for other options.  It seems to me that libdispatch 
(http://libdispatch.macosforge.org/) could be a nice replacement for pthreads, 
and it seems that there are some ports to Windows too (although I am not sure 
how advanced they are).

You may have other suggestions too, which I will be glad to discuss.  For the 
time being I am not going to apply your patches, as it seems to me that these 
are introducing GPL in numexpr, and I would like to avoid this.

Francesc

Original comment by fal...@gmail.com on 14 Jul 2013 at 2:56

GoogleCodeExporter commented 9 years ago 
Hi guys,

Sorry I missed the initial mail (the one sent years ago), but I can't find it 
in my gmail archive so it must have been eaten as spam by one of my 
thunderbirds. I responded to your e-mail Francesc, granting you the right to 
use pthread.c and pthread.h as originally authored by me under BSD license.

Do you guys need me do anything more? Written statements, blood-signing, etc.?

Andrzej Haczewski

Original comment by ahaczewski@gmail.com on 14 Jul 2013 at 4:25

GoogleCodeExporter commented 9 years ago 
Hi Andrzej,

Thank you very much for agreeing releasing your code under the BSD license!  As 
I already stated in a private e-mail MIT would actually be a better match for 
the projects in which I'm using your code, currently numexpr and Blosc 
(http://blosc.org).

I am not sure how we can translate that to the libraries using your code 
(win32/pthread.h and win32/pthread.c), but perhaps we could add the your 
sentence to the header so that it would read like this:

/*


What do you think, would that be enough?

Also, Andrzej, could you double check that the code that we include in numexpr 
has all been made by you?  If not, then we would need to ask other possible 
contributors (like Johannes Sixt <j6t@kdbg.org> or Junio C Hamano 
<gitster@pobox.com>) to give their approval for using the MIT license here.

Thanks again!

Francesc

Original comment by fal...@gmail.com on 14 Jul 2013 at 5:02

GoogleCodeExporter commented 9 years ago 
Hi Francesc, hi Andrzej,
thank you very much for your quick reply.

It seems to me that the win32/pthread.* version currently used in numexpr (and 
blosc) is a modified version of [1] so probably also Johannes Sixt should be 
asked for permission to use its patches under the MIT (or BSD) license.

[1] https://github.com/git/git/commit/947c3464e49522c55296a8191aed7946bd0f4308

Antonio

Original comment by a.valent...@gmail.com on 14 Jul 2013 at 6:01

GoogleCodeExporter commented 9 years ago 
Francesc, I think it is enough to change header comment of pthread.c and .h to 
this:

/*


I don't see the need to include my statement there, I will restate it below for 
traceability and accountability and that should be enough.

I, Andrzej K. Haczewski, hereby grant the permission to use 
compat/win32/pthread.c and compat/win32/pthread.h files as originally authored 
and signed off by me in 
https://github.com/git/git/commit/44626dc7d562d23b54d969bb73ddeda12d5602e9 
under the terms of MIT license.

The patch was signed off by Johannes Sixt <j6t@kdbg.org> and Junio C Hamano 
<gitster@pobox.com> but AFAICT only Johannes made some minor adjustments to the 
original patch that I've submitted before passing it up to Junio for a final 
commit. But you might ask Junio's permission as well.

Johannes made an improvement some time later with patch 
https://github.com/git/git/commit/947c3464e49522c55296a8191aed7946bd0f4308 
adding pthread_cond_broadcast implementation.

Best regards,
Andrzej Haczewski

Original comment by ahaczewski@gmail.com on 14 Jul 2013 at 10:18

GoogleCodeExporter commented 9 years ago 
Thanks Andrzej.  Your suggestion of including the body of the license in the 
source files makes a lot of sense to me.  If Johannes and Junio give their 
approval, I'll make sure to update the pthread.c and pthread.h files 
accordingly.

Francesc

Original comment by fal...@gmail.com on 14 Jul 2013 at 10:40

GoogleCodeExporter commented 9 years ago 
OK, I have updated the comment header of win32/pthread.* as suggested by 
Andrzej [1].

IMO patches can be merged now.

[1] 
https://code.google.com/r/avalentinoit-numexpr/source/detail?r=4bc3037d3a0c7eb45
7954029c934b97cc9b5ad21

cheers

--
Antonio Valentino

Original comment by a.valent...@gmail.com on 16 Jul 2013 at 4:47

GoogleCodeExporter commented 9 years ago 
Changes merged.  Closing this

Original comment by fal...@gmail.com on 26 Aug 2013 at 4:46