Upgrading to commit c7e1c457a20e452eae02c9c09ada2bbd2f301ccc on M3.4 fails

[matthullulcc]

Hi,

Can you please invesitigate the issue i am encountering when trying to upgrade mod_tab to the latest commit?

I have added the error message below and if you have any questions please let me know, Matt

upgrading moodle db -->mod_tab Default exception handler: Unknown error upgrading mod_tab to version 2017121400, can not continue. Debug: Error code: upgradeerror

• line 304 of /lib/upgradelib.php: upgrade_exception thrown
• line 811 of /lib/upgradelib.php: call to upgrade_mod_savepoint()
• line 508 of /lib/upgradelib.php: call to upgrade_plugins_modules()
• line 1850 of /lib/upgradelib.php: call to upgrade_plugins()
• line 181 of /admin/cli/upgrade.php: call to upgrade_noncore()

!!! Unknown error upgrading mod_tab to version 2017121400, can not continue. !!! !! Error code: upgradeerror !! !! Stack trace: * line 304 of /lib/upgradelib.php: upgrade_exception thrown

• line 811 of /lib/upgradelib.php: call to upgrade_mod_savepoint()
• line 508 of /lib/upgradelib.php: call to upgrade_plugins_modules()
• line 1850 of /lib/upgradelib.php: call to upgrade_plugins()
• line 181 of /admin/cli/upgrade.php: call to upgrade_noncore() !! moodle upgrade failed.

[aferenz]

Hi,

there is a missing line in the db/upgrade.php The xmldb_tab_upgrade function should always return true

so return true; should be added before the ending curly bracket