ooibc88 / blockbench

BLOCKBENCH: A Framework for Analyzing Private Blockchains. Blockbench contains workloads for measuring the data processing performance, and workloads for understanding the performance of different layers of Blockchain systems.
https://www.comp.nus.edu.sg/~dbsystem/fabricsharp/#/blockbench
Apache License 2.0
391 stars 174 forks source link

Enhancement: Remove hard-coded stuff and use configuration file(s) instead #35

Open herrBez opened 6 years ago

herrBez commented 6 years ago

The project is very difficult to configure (indeed I am having a very hard time): it is due on the one hand to the repetition of environment declarations and on the other hand to the plenty of hard-coded configuration variables (e.g., dinhtta repeated in all files).

Therefore, it would be very helpful to adhere to the DRY principle and therefore avoid repetition and redeclaration of variables and hardcoded stuff. I would suggest using only a single configuration file in which all configuration variables are defined or even multiple files and a standard format, e.g. json, and using a command line tool, such as jq to read the configuration data.

phucnguyenit commented 6 years ago

totally agree with you!

yamarkz commented 6 years ago

totally agree with you!

ug93tad commented 6 years ago

see the new commits. We've removed some of the hardcoded stuff

yogesa commented 1 year ago

too hard to configure