search

ooici / coverage-model

BSD 2-Clause "Simplified" License
2 stars 9 forks source link

is_empty #172

Closed lukecampbell closed 10 years ago

lukecampbell commented 10 years ago

Add an is_empty() method to the Coverage interface and remove insert_timesteps and num_timesteps.

We came to the same conclusion, that the number of timesteps for a coverage is irrelevant and misleading.

caseybryant commented 10 years ago

I implemented the is_empty method in commit . Your note indicates that you want the insert_timesteps and num_timesteps methods removed as well, but we didn't talk about this. I'm okay with removing them. Is that what you want?

lukecampbell commented 10 years ago

Yeah can we get rid of them?

It'll cause a few test hiccups but they're misleading now, I think.

caseybryant commented 10 years ago

Insert time steps has been removed. I retooled num_timesteps. Spins through all the data and calculates the number of time steps. It's accurate, but I can remove it if you thin it is still misleading.